d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hyperv/hn: Reset do_lro, if the hash types are not TCP related.

Browse Source 
Mainly because the host side only set TCPCS and IPCS even for
UDP datagrams.

MFC after:	1 week
Sponsored by:	Microsoft
Differential Revision:	https://reviews.freebsd.org/D8369
This commit is contained in:
Sepherosa Ziehau 2016-10-31 05:05:12 +00:00
parent 7ccc20da6a
commit 82d71ca917
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=308119
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
View File

@ -1754,6 +1754,13 @@ hn_rxpkt(struct hn_rx_ring *rxr, const void *data, int dlen,
rxr->hn_csum_udp++;
}
/*
* XXX
* As of this write (Oct 28th, 2016), host side will turn
* on only TCPCS_OK and IPCS_OK even for UDP datagrams, so
* the do_lro setting here is actually _not_ accurate. We
* depend on the RSS hash type check to reset do_lro.
*/
if ((info->csum_info &
(NDIS_RXCSUM_INFO_TCPCS_OK | NDIS_RXCSUM_INFO_IPCS_OK)) ==
(NDIS_RXCSUM_INFO_TCPCS_OK | NDIS_RXCSUM_INFO_IPCS_OK))
@ -1828,9 +1835,16 @@ hn_rxpkt(struct hn_rx_ring *rxr, const void *data, int dlen,
NDIS_HASH_FUNCTION_TOEPLITZ) {
uint32_t type = (info->hash_info & NDIS_HASH_TYPE_MASK);
/*
* NOTE:
* do_lro is resetted, if the hash types are not TCP
* related. See the comment in the above csum_flags
* setup section.
*/
switch (type) {
case NDIS_HASH_IPV4:
hash_type = M_HASHTYPE_RSS_IPV4;
do_lro = 0;
break;
case NDIS_HASH_TCP_IPV4:
@ -1839,10 +1853,12 @@ hn_rxpkt(struct hn_rx_ring *rxr, const void *data, int dlen,
case NDIS_HASH_IPV6:
hash_type = M_HASHTYPE_RSS_IPV6;
do_lro = 0;
break;
case NDIS_HASH_IPV6_EX:
hash_type = M_HASHTYPE_RSS_IPV6_EX;
do_lro = 0;
break;
case NDIS_HASH_TCP_IPV6: