d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that the SCTP iterator runs with an stcb and inp, which belong to

Browse Source 
each other.

Reported by:	syzbot+82d39d14f2f765e38db0@syzkaller.appspotmail.com
MFC after:	3 days
This commit is contained in:
Michael Tuexen 2020-05-10 22:54:30 +00:00
parent a93817e04f
commit 83ed508055
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=360885
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netinet/sctputil.c
View File

@ -1489,6 +1489,7 @@ sctp_iterator_work(struct sctp_iterator *it)
}
tinp = it->inp;
it->inp = LIST_NEXT(it->inp, sctp_list);
it->stcb = NULL;
SCTP_INP_RUNLOCK(tinp);
if (it->inp == NULL) {
goto done_with_iterator;
@ -1558,6 +1559,9 @@ sctp_iterator_work(struct sctp_iterator *it)
atomic_add_int(&it->stcb->asoc.refcnt, -1);
iteration_count = 0;
}
KASSERT(it->inp == it->stcb->sctp_ep,
("%s: stcb %p does not belong to inp %p, but inp %p",
__func__, it->stcb, it->inp, it->stcb->sctp_ep));
/* run function on this one */
(*it->function_assoc) (it->inp, it->stcb, it->pointer, it->val);
@ -1590,6 +1594,7 @@ sctp_iterator_work(struct sctp_iterator *it)
} else {
it->inp = LIST_NEXT(it->inp, sctp_list);
}
it->stcb = NULL;
if (it->inp == NULL) {
goto done_with_iterator;
}