From 8464e56e2aa4d9989177c6899c906f3499e4c999 Mon Sep 17 00:00:00 2001 From: Cy Schubert Date: Sat, 21 Sep 2013 14:22:07 +0000 Subject: [PATCH] Check return code from inet_pton. Discovered by: Coverity. Approved by: glebius (mentor) Approved by: re (blanket) --- contrib/ipfilter/ip_fil.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/contrib/ipfilter/ip_fil.c b/contrib/ipfilter/ip_fil.c index 208602a02057..9178bd325d38 100644 --- a/contrib/ipfilter/ip_fil.c +++ b/contrib/ipfilter/ip_fil.c @@ -228,7 +228,19 @@ ipf_setifpaddr(ifp, addr) sin6 = (struct sockaddr_in6 *)&ifa->ifa_addr; sin6->sin6_family = AF_INET6; - inet_pton(AF_INET6, addr, &sin6->sin6_addr); + /* Abort if bad address. */ + switch (inet_pton(AF_INET6, addr, &sin6->sin6_addr)) + { + case 1: + break; + case -1: + perror("inet_pton"); + abort(); + break; + default: + abort(); + break; + } } else #endif {