d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix atime handling.

Browse Source 
Previously, the atime-modifying vnops called ZFS_ACCESSTIME_STAMP()
followed by zfs_inode_update() to update the atime.  However, since atimes
are cached in the znode for delayed writing, the zfs_inode_update()
function would effectively ignore the cached atime by reading it from
the SA.

This commit moves the updating of the atime in the inode into
zfs_tstamp_update_setup() which is called by the ZFS_ACCESSTIME_STAMP()
macro and eliminates the call to zfs_inode_update() in the atime-modifying
vnops.

It's possible the same thing could have been done directly in
zfs_inode_update() but I wasn't sure that it was safe in all cases where
it is called.

The effect is that atime handling is as if "strictatime" were selected;
even if the filesystem is mounted with "relatime".

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #1949
This commit is contained in:
Tim Chase 2013-12-10 16:36:42 -06:00 committed by Brian Behlendorf
parent 5cb65efe2c
commit 84b0aac5fd
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
module/zfs/zfs_vnops.c
View File

@ -559,7 +559,6 @@ zfs_read(struct inode *ip, uio_t *uio, int ioflag, cred_t *cr)
zfs_range_unlock(rl);
ZFS_ACCESSTIME_STAMP(zsb, zp);
zfs_inode_update(zp);
ZFS_EXIT(zsb);
return (error);
}
@ -2148,7 +2147,6 @@ zfs_readdir(struct inode *ip, struct dir_context *ctx, cred_t *cr)
error = 0;
ZFS_ACCESSTIME_STAMP(zsb, zp);
zfs_inode_update(zp);
out:
ZFS_EXIT(zsb);
@ -3681,7 +3679,6 @@ zfs_readlink(struct inode *ip, uio_t *uio, cred_t *cr)
mutex_exit(&zp->z_lock);
ZFS_ACCESSTIME_STAMP(zsb, zp);
zfs_inode_update(zp);
ZFS_EXIT(zsb);
return (error);
}

2
module/zfs/zfs_znode.c
View File

@ -1123,6 +1123,8 @@ zfs_tstamp_update_setup(znode_t *zp, uint_t flag, uint64_t mtime[2],
if (flag & ATTR_ATIME) {
ZFS_TIME_ENCODE(&now, zp->z_atime);
ZTOI(zp)->i_atime.tv_sec = zp->z_atime[0];
ZTOI(zp)->i_atime.tv_nsec = zp->z_atime[1];
}
if (flag & ATTR_MTIME) {