d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't count PHY errors as input errors. This is important for

Browse Source 
5212-based devices because PHY errors are used to collect data
on environmental noise that and doesn't truly reflect the state
of the communications media.  The result is confused users.
Folks that want to watch PHY errors can still get the statistics
through the device ioctl (used by athstats).
This commit is contained in:
Sam Leffler 2003-11-13 05:35:07 +00:00
parent b9e25f436b
commit 85643802a4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=122602
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/ath/if_ath.c
View File

@ -1633,7 +1633,6 @@ ath_rx_proc(void *arg, int npending)
break;
TAILQ_REMOVE(&sc->sc_rxbuf, bf, bf_list);
if (ds->ds_rxstat.rs_status != 0) {
ifp->if_ierrors++;
if (ds->ds_rxstat.rs_status & HAL_RXERR_CRC)
sc->sc_stats.ast_rx_crcerr++;
if (ds->ds_rxstat.rs_status & HAL_RXERR_FIFO)
@ -1644,6 +1643,15 @@ ath_rx_proc(void *arg, int npending)
sc->sc_stats.ast_rx_phyerr++;
phyerr = ds->ds_rxstat.rs_phyerr & 0x1f;
sc->sc_stats.ast_rx_phy[phyerr]++;
} else {
/*
* NB: don't count PHY errors as input errors;
* we enable them on the 5212 to collect info
* about environmental noise and, in that
* setting, they don't really reflect tx/rx
* errors.
*/
ifp->if_ierrors++;
}
goto rx_next;
}