d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bad logic in iovlist_truncate().

Browse Source 
To conform to RFC 5426, this function is intended to truncate messages
if they exceed the message size limits. Unfortunately, the amount of
space was computed the wrong way around, causing messages to be
truncated entirely.

Reported by:	Michael Grimm on stable@
MFC after:	3 days
This commit is contained in:
Ed Schouten 2018-06-18 06:01:28 +00:00
parent 8a3255c288
commit 8803b8597a
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=335314
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
usr.sbin/syslogd/syslogd.c
View File

@ -1613,8 +1613,8 @@ iovlist_truncate(struct iovlist *il, size_t size)
struct iovec *last;
size_t diff;
while (size > il->totalsize) {
diff = size - il->totalsize;
while (il->totalsize > size) {
diff = il->totalsize - size;
last = &il->iov[il->iovcnt - 1];
if (diff >= last->iov_len) {
/* Remove the last iovec entirely. */