From 896eb70c80d1058e5b63f37c152fdafbe4452d66 Mon Sep 17 00:00:00 2001 From: Edward Tomasz Napierala Date: Fri, 11 May 2018 14:52:35 +0000 Subject: [PATCH] Set kldxref_enable="YES" for ARM images. Without it, the images are missing the /boot/kernel/linker.hints file, which breaks loading some of the modules with dependencies, eg cfiscsi.ko. This is a minimal fix for ARM images, in order to safely MFC it before 11.2-RELEASE. Afterwards, however, I believe we should actually just change the default (as in, etc/defaults/rc.conf). The reason is that it's required for every image that's being cross-built, as kldxref(1) cannot handle files for non-native architectures. For the one that is not - amd64 - having it on by default doesn't change anything - the script is noop if the linker.hints already exists. The long-term solution would be to rewrite kldxref(1) to handle other architectures, and generate linker.hints at build time. Reviewed by: gjb@ MFC after: 3 days Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D14534 --- release/tools/arm.subr | 1 + 1 file changed, 1 insertion(+) diff --git a/release/tools/arm.subr b/release/tools/arm.subr index c5adbaf063d7..4bf2f06f2d29 100644 --- a/release/tools/arm.subr +++ b/release/tools/arm.subr @@ -122,6 +122,7 @@ arm_install_base() { echo 'sendmail_outbound_enable="NO"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf echo 'sendmail_msp_queue_enable="NO"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf echo 'growfs_enable="YES"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf + echo 'kldxref_enable="YES"' >> ${CHROOTDIR}/${DESTDIR}/etc/rc.conf sync umount_loop ${CHROOTDIR}/${DESTDIR}