d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix -S with -l not being atomic.

Browse Source 
It was unlinking the target even though it uses rename(2) which already
effectively does that.  -S is intended to not unlink(2) the target first.

MFC after:	1 week
Reviewed by:	jhb
Sponsored by:	EMC / Isilon Storage Division
Differential Revision:	https://reviews.freebsd.org/D7452
This commit is contained in:
Bryan Drewery 2016-08-10 18:19:08 +00:00
parent 49cfff9131
commit 89ad63ad2d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=303931
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
usr.bin/xinstall/xinstall.c
View File

@ -536,7 +536,6 @@ do_link(const char *from_name, const char *to_name,
if (verbose)
printf("install: link %s -> %s\n",
from_name, to_name);
unlink(to_name);
ret = rename(tmpl, to_name);
/*
* If rename has posix semantics, then the temporary
@ -580,8 +579,6 @@ do_symlink(const char *from_name, const char *to_name,
if (target_sb->st_flags & NOCHANGEBITS)
(void)chflags(to_name, target_sb->st_flags &
~NOCHANGEBITS);
unlink(to_name);
if (verbose)
printf("install: symlink %s -> %s\n",
from_name, to_name);