Fix -S with -l not being atomic.
It was unlinking the target even though it uses rename(2) which already effectively does that. -S is intended to not unlink(2) the target first. MFC after: 1 week Reviewed by: jhb Sponsored by: EMC / Isilon Storage Division Differential Revision: https://reviews.freebsd.org/D7452
This commit is contained in:
parent
49cfff9131
commit
89ad63ad2d
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=303931
@ -536,7 +536,6 @@ do_link(const char *from_name, const char *to_name,
|
|||||||
if (verbose)
|
if (verbose)
|
||||||
printf("install: link %s -> %s\n",
|
printf("install: link %s -> %s\n",
|
||||||
from_name, to_name);
|
from_name, to_name);
|
||||||
unlink(to_name);
|
|
||||||
ret = rename(tmpl, to_name);
|
ret = rename(tmpl, to_name);
|
||||||
/*
|
/*
|
||||||
* If rename has posix semantics, then the temporary
|
* If rename has posix semantics, then the temporary
|
||||||
@ -580,8 +579,6 @@ do_symlink(const char *from_name, const char *to_name,
|
|||||||
if (target_sb->st_flags & NOCHANGEBITS)
|
if (target_sb->st_flags & NOCHANGEBITS)
|
||||||
(void)chflags(to_name, target_sb->st_flags &
|
(void)chflags(to_name, target_sb->st_flags &
|
||||||
~NOCHANGEBITS);
|
~NOCHANGEBITS);
|
||||||
unlink(to_name);
|
|
||||||
|
|
||||||
if (verbose)
|
if (verbose)
|
||||||
printf("install: symlink %s -> %s\n",
|
printf("install: symlink %s -> %s\n",
|
||||||
from_name, to_name);
|
from_name, to_name);
|
||||||
|
Loading…
Reference in New Issue
Block a user