d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bhyvectl: do not return garbage from send_message

Browse Source 
err is used uninitialized in some cases.

Reviewed by:		corvink, markj
MFC after:		1 week
Sponsored by:		vStack
Differential Revision:	https://reviews.freebsd.org/D38886
This commit is contained in:
Vitaliy Gusev 2023-03-06 12:27:10 +01:00 committed by Corvin Köhne
parent ee10c61d7a
commit 89fe7b98fe
No known key found for this signature in database
GPG Key ID: D854DA56315E026A
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/bhyvectl/bhyvectl.c
View File

@ -1679,12 +1679,12 @@ static int
send_message(const char *vmname, nvlist_t *nvl)
{
struct sockaddr_un addr;
int err, socket_fd;
int err = 0, socket_fd;
socket_fd = socket(PF_UNIX, SOCK_STREAM, 0);
if (socket_fd < 0) {
perror("Error creating bhyvectl socket");
err = -1;
err = errno;
goto done;
}
@ -1700,8 +1700,10 @@ send_message(const char *vmname, nvlist_t *nvl)
goto done;
}
if (nvlist_send(socket_fd, nvl) < 0)
if (nvlist_send(socket_fd, nvl) < 0) {
perror("nvlist_send() failed");
err = errno;
}
nvlist_destroy(nvl);
done: