d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Put an XXX: comment here to point out a couple of free() issues on

Browse Source 
pnp_read_bytes().

Spotted by:	FlexeLint
This commit is contained in:
Poul-Henning Kamp 2002-10-16 10:40:43 +00:00
parent 633eb1fc9e
commit 8b7f9bdcdf
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=105226
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/isa/pnp.c
View File

@ -639,6 +639,10 @@ pnp_create_devices(device_t parent, pnp_id *p, int csn,
* bytes already in the buffer should be passed in '*lenp'. The memory
* allocated will be returned in '*resourcesp' with its size and the
* number of bytes of resources in '*spacep' and '*lenp' respectively.
*
* XXX: Multiple problems here, we forget to free() stuff in one
* XXX: error return, and in another case we free (*resourcesp) but
* XXX: don't tell the caller.
*/
static int
pnp_read_bytes(int amount, u_char **resourcesp, int *spacep, int *lenp)