followup to r329556, completely remove the covered vnode assert
vrele() acquires the vnode lock only if the hold count drops to zero. In other scenarios it needs only the interlock. So, zfsctl_snapdir_lookup() can race with vfs_mount_destroy() -> vrele() such that the lookup adds a new reference and then vrele() drops the mountpoint's reference and only then we check the reference count. It would be just one in this case. In fact, the assert should have been removed in r323483 when the code learned how to deal with the uncovered vnode. PR: 225795 MFC after: 4 days X-MFC with: r329556
This commit is contained in:
parent
0028abe633
commit
8d69fe5cc8
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=329820
@ -975,13 +975,6 @@ zfsctl_snapdir_lookup(ap)
|
||||
if (VOP_ISLOCKED(*vpp) == LK_EXCLUSIVE)
|
||||
break;
|
||||
|
||||
/*
|
||||
* The vnode must be referenced at least by this thread and
|
||||
* the mount point or the thread doing the mounting.
|
||||
* There can be more references from concurrent lookups.
|
||||
*/
|
||||
KASSERT((*vpp)->v_holdcnt > 1, ("found unheld mountpoint"));
|
||||
|
||||
/*
|
||||
* Check if a snapshot is already mounted on top of the vnode.
|
||||
*/
|
||||
|
Loading…
Reference in New Issue
Block a user