d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nfscl: Fix handling of nd_slotid while handling NFSERR_BADSESSION

Browse Source 
When the NFSv4.1/4.2 client is handling a server error
of NFSERR_BADSESSION, it retries RPCs with a new session.
Without this patch, the nd_slotid was not being updated
for the new session.

This would result in a bogus console message like
"Wrong session srvslot=X slot=Y" and then it would
free the incorrect slot, often generating a
"freeing free slot!!" console message as well.

This patch fixes the problem.

Note that FreeBSD NFSv4.1/4.2 servers only
generate a NFSERR_BADSESSION error after a reboot
or after a client does a DestroySession operation.

PR:	260011
MFC after:	1 week
This commit is contained in:
Rick Macklem 2022-08-25 20:48:04 -07:00
parent 2b612c9d3b
commit 8e59ec29e4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/fs/nfs/nfs_commonkrpc.c
View File

@ -1169,6 +1169,9 @@ newnfs_request(struct nfsrv_descript *nd, struct nfsmount *nmp,
*tl++ = txdr_unsigned(slotseq);
*tl++ = txdr_unsigned(slotpos);
*tl = txdr_unsigned(maxslot);
if ((nd->nd_flag &
ND_HASSLOTID) != 0)
nd->nd_slotid = slotpos;
}
if (reterr == NFSERR_BADSESSION ||
reterr == 0) {