d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some comments about the deficiencies of this module. I had hoped to get

Browse Source 
around to addressing them some more, but Real Life (tm) has gotten in the
way.
This commit is contained in:
gordon 2003-02-07 17:50:33 +00:00
parent 472a3ee302
commit 8ee7a379eb
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/geom/geom_vol_ffs.c
View File

@ -76,6 +76,10 @@ g_vol_ffs_taste(struct g_class *mp, struct g_provider *pp, int flags)
g_trace(G_T_TOPOLOGY, "vol_taste(%s,%s)", mp->name, pp->name);
g_topology_assert();
/*
* XXX This is a really weak way to make sure we don't recurse.
* Probably ought to use BIO_GETATTR to check for this.
*/
if (flags == G_TF_NORMAL &&
!strcmp(pp->geom->class->name, VOL_FFS_CLASS_NAME))
return (NULL);
@ -118,6 +122,9 @@ g_vol_ffs_taste(struct g_class *mp, struct g_provider *pp, int flags)
g_free(fs);
continue;
}
/* XXX We need to check for namespace conflicts. */
/* XXX How do you handle a mirror set? */
/* XXX We don't validate the volume name. */
g_topology_lock();
/* Alright, we have a label and a volume name, reconfig. */
g_slice_config(gp, 0, G_SLICE_CONFIG_SET, (off_t) 0,