d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

symorder appears to have been designed to run on executable files

Browse Source 
only, as it payes no attention to the relocation table (which
references the symbols).

As a result, running "symorder -c" to clean up the visibility of a LKM
".o" file (as is done in the new bsd.kmod.mk) totally screws up the
relocation table, making the LKM file unloadable. (ld: bogus
relocation record)

This is a pretty crude fix - I've changed symorder so that when
running in "cleanup" mode, it disables the reordering which was
screwing up the relocation table.  I'm sure there is a better fix, but
I didn't have the energy.  Feel free to fix this hack, probably by
renumbering the symbol indexes in the relocation table.
This commit is contained in:
peter 1995-10-28 12:27:20 +00:00
parent b7d0978d02
commit 90d5861925
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
usr.bin/symorder/symorder.c
View File

@ -185,15 +185,19 @@ main(argc, argv)
strtabsize - sizeof(int))
badfmt("corrupted string table");
newtab = (struct nlist *)malloc(n);
if (newtab == (struct nlist *)NULL)
error(NULL);
memset(newtab, 0, n);
i = n / sizeof(struct nlist);
reorder(symtab, newtab, i);
free((void *)symtab);
symtab = newtab;
if (!clean) {
newtab = (struct nlist *)malloc(n);
if (newtab == (struct nlist *)NULL)
error(NULL);
memset(newtab, 0, n);
reorder(symtab, newtab, i);
free((void *)symtab);
symtab = newtab;
} else {
symfound = symkept = i;
}
newstrings = malloc(strtabsize);
if (newstrings == NULL)