d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a bogus assertion from the gic drivers

Browse Source 
When setting a message based interrupt range we set the base and count.
In an earlier the count was implemented as an end value, however the
asserts used to check this value was correct were incorrectly left in.

Reported by:	emaste
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Andrew Turner 2021-09-14 19:03:30 +00:00
parent c782ea8bb5
commit 90f33f34ba
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/arm/arm/gic.c
View File

@ -538,8 +538,6 @@ arm_gic_write_ivar(device_t dev, device_t child, int which, uintptr_t value)
case GIC_IVAR_MBI_COUNT:
MPASS(sc->sc_spi_start != 0);
MPASS(sc->sc_spi_count == 0);
MPASS(value >= sc->sc_spi_start);
MPASS(value >= GIC_FIRST_SPI);
sc->sc_spi_count = value;
sc->sc_spi_end = sc->sc_spi_start + sc->sc_spi_count;

2
sys/arm64/arm64/gic_v3.c
View File

@ -506,8 +506,6 @@ gic_v3_write_ivar(device_t dev, device_t child, int which, uintptr_t value)
case GIC_IVAR_MBI_COUNT:
MPASS(sc->gic_mbi_start != 0);
MPASS(sc->gic_mbi_end == 0);
MPASS(value >= sc->gic_mbi_start);
MPASS(value >= GIC_FIRST_SPI);
sc->gic_mbi_end = value - sc->gic_mbi_start;