Fix the following -Werror warning from clang 3.5.0, while building
rtld-elf for powerpc 32 bit: libexec/rtld-elf/powerpc/reloc.c:486:6: error: taking the absolute value of unsigned type 'Elf_Addr' (aka 'unsigned int') has no effect [-Werror,-Wabsolute-value] if (abs(offset) < 32*1024*1024) { /* inside 32MB? */ ^ libexec/rtld-elf/powerpc/reloc.c:486:6: note: remove the call to 'abs' since unsigned values cannot be negative if (abs(offset) < 32*1024*1024) { /* inside 32MB? */ ^~~ 1 error generated. Cast 'offset' to int, since that was intended, and should be safe to do on architectures with 32-bit two's complement ints. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D1387
This commit is contained in:
parent
84267cacf4
commit
918428b837
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=276342
@ -483,7 +483,7 @@ reloc_jmpslot(Elf_Addr *wherep, Elf_Addr target, const Obj_Entry *defobj,
|
||||
*/
|
||||
offset = target - (Elf_Addr)wherep;
|
||||
|
||||
if (abs(offset) < 32*1024*1024) { /* inside 32MB? */
|
||||
if (abs((int)offset) < 32*1024*1024) { /* inside 32MB? */
|
||||
/* b value # branch directly */
|
||||
*wherep = 0x48000000 | (offset & 0x03fffffc);
|
||||
__syncicache(wherep, 4);
|
||||
|
Loading…
Reference in New Issue
Block a user