d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

madt_setup_local: convert series of strcmp to iteration over the array

Browse Source 
to prepare for one more addition

Reviewed by:	markj
Tested by:	David Sebek <dasebek@gmail.com>
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D30624
This commit is contained in:
Konstantin Belousov 2021-06-03 01:19:09 +03:00
parent a603d41aca
commit 92adf00d05
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sys/x86/acpica/madt.c
View File

@ -128,6 +128,11 @@ madt_probe_cpus(void)
return (0);
}
static const char *x2apic_sandy_dis[] = {
"LENOVO",
"ASUSTeK Computer Inc.",
};
/*
* Initialize the local APIC on the BSP.
*/
@ -139,7 +144,7 @@ madt_setup_local(void)
const char *reason;
char *hw_vendor;
u_int p[4];
int user_x2apic;
int i, user_x2apic;
bool bios_x2apic;
if ((cpu_feature2 & CPUID2_X2APIC) != 0) {
@ -173,21 +178,22 @@ madt_setup_local(void)
CPUID_TO_MODEL(cpu_id) == 0x2a) {
hw_vendor = kern_getenv("smbios.planar.maker");
/*
* It seems that some Lenovo and ASUS
* SandyBridge-based notebook BIOSes have a
* bug which prevents booting AP in x2APIC
* mode. Since the only way to detect mobile
* CPU is to check northbridge pci id, which
* cannot be done that early, disable x2APIC
* for all Lenovo and ASUS SandyBridge
* It seems that some SandyBridge-based
* notebook BIOSes have a bug which prevents
* booting AP in x2APIC mode. Since the only
* way to detect mobile CPU is to check
* northbridge pci id, which cannot be done
* that early, disable x2APIC for all such
* machines.
*/
if (hw_vendor != NULL) {
if (!strcmp(hw_vendor, "LENOVO") ||
!strcmp(hw_vendor,
"ASUSTeK Computer Inc.")) {
reason =
for (i = 0; i < nitems(x2apic_sandy_dis); i++) {
if (strcmp(hw_vendor,
x2apic_sandy_dis[i]) == 0) {
reason =
"for a suspected SandyBridge BIOS bug";
break;
}
}
freeenv(hw_vendor);
}