From 949690303259f8e5fb245044cef9e670231c7c9e Mon Sep 17 00:00:00 2001 From: Guido van Rooij Date: Mon, 15 Aug 1994 19:44:50 +0000 Subject: [PATCH] Plug security hole that was already fixed in 1.1. It prevents user from specifying their hostname when rlogin()-ing in (using rlogin -f-h) Reviewed by: Submitted by: --- libexec/rlogind/rlogind.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libexec/rlogind/rlogind.c b/libexec/rlogind/rlogind.c index 6f5f5e1d4716..57927985f42d 100644 --- a/libexec/rlogind/rlogind.c +++ b/libexec/rlogind/rlogind.c @@ -293,6 +293,11 @@ doit(f, fromp) if (f > 2) /* f should always be 0, but... */ (void) close(f); setup_term(0); + if (strchr(lusername, '-')) { + syslog(LOG_ERR, "tried to pass user \"%s\" to login", + lusername); + fatal(STDERR_FILENO, "invalid user", 0); + } if (authenticated) { #ifdef KERBEROS if (use_kerberos && (pwd->pw_uid == 0))