d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify some comments in the MIPS makecontext().

Browse Source 
- N32 and N64 do not have a $a0-3 gap.
- Use 'sp += 4' to skip over the gap for O32 rather than '+= i'.  It
  doesn't make a functional change, but makes the code match the comment.

Sponsored by:	DARPA / AFRL
This commit is contained in:
John Baldwin 2018-01-27 00:39:49 +00:00
parent d3f19d3f57
commit 95c4f0f257
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=328457
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/libc/mips/gen/makecontext.c
View File

@ -95,19 +95,18 @@ __makecontext(ucontext_t *ucp, void (*func)(void), int argc, ...)
for (i = 0; i < argc && i < 4; i++)
/* LINTED register_t is safe */
mc->mc_regs[A0 + i] = va_arg(ap, register_t);
/* Pass remaining arguments on the stack above the $a0-3 gap. */
sp += i;
/* Skip over the $a0-3 gap. */
sp += 4;
#endif
#if defined(__mips_n32) || defined(__mips_n64)
/* Up to the first 8 arguments are passed in $a0-7. */
for (i = 0; i < argc && i < 8; i++)
/* LINTED register_t is safe */
mc->mc_regs[A0 + i] = va_arg(ap, register_t);
/* Pass remaining arguments on the stack above the $a0-3 gap. */
#endif
/* Pass remaining arguments on the stack above the $a0-3 gap. */
/* Pass remaining arguments on the stack. */
for (; i < argc; i++)
/* LINTED uintptr_t is safe */
/* LINTED register_t is safe */
*sp++ = va_arg(ap, register_t);
va_end(ap);
}