d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nvme: Add comments about other fields in status

Browse Source 
When manually completing an I/O, we do so because we have no status back
from the card. Note M, CRD and P are all 0 because this is an artificial
event (and phase isn't checked when it's completed this way). There's no
MORE information in the error log page and there's no delayed retry
(CRD=0) and we don't currently request CRD to be set to anything other
than 0 and thus don't implement delayed retry.

Sponsored by:		Netflix
Reviewed by:		chuck, mav, jhb
Differential Revision:	https://reviews.freebsd.org/D41314
This commit is contained in:
Warner Losh 2023-08-07 16:36:14 -06:00
parent a510dbc848
commit 95cd10f139
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/nvme/nvme_qpair.c
View File

@ -503,6 +503,9 @@ nvme_qpair_manual_complete_tracker(
cpl.status |= (sct & NVME_STATUS_SCT_MASK) << NVME_STATUS_SCT_SHIFT;
cpl.status |= (sc & NVME_STATUS_SC_MASK) << NVME_STATUS_SC_SHIFT;
cpl.status |= (dnr & NVME_STATUS_DNR_MASK) << NVME_STATUS_DNR_SHIFT;
/* M=0 : this is artificial so no data in error log page */
/* CRD=0 : this is artificial and no delayed retry support anyway */
/* P=0 : phase not checked */
nvme_qpair_complete_tracker(tr, &cpl, print_on_error);
}