d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bhyve/snapshot: limit snapshot filename to NAME_MAX

Browse Source 
NAME_MAX is a better fit since strcat_extension() constructs the
filename of the snapshot file.

Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D34291
This commit is contained in:
Robert Wing 2022-03-17 21:51:31 -08:00
parent 3efc45f34e
commit 961e6a12ef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/bhyve/snapshot.c
View File

@ -181,10 +181,10 @@ strcat_extension(const char *base_str, const char *ext)
char *res;
size_t base_len, ext_len;
base_len = strnlen(base_str, MAX_VMNAME);
ext_len = strnlen(ext, MAX_VMNAME);
base_len = strnlen(base_str, NAME_MAX);
ext_len = strnlen(ext, NAME_MAX);
if (base_len + ext_len > MAX_VMNAME) {
if (base_len + ext_len > NAME_MAX) {
fprintf(stderr, "Filename exceeds maximum length.\n");
return (NULL);
}