d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use named field's initializer when constructing <foo>_platform structure.

Browse Source 
In current code, the delay argument in FDT_PLATFORM_DEF(2) improperly
initialize refs field from kobj_class structure instead of delay_count
field.
This causes not working DELAY() function (due to never initialized
delay_count) in earlier boot stages, until the first timer was attached.

MFC after:	2 weeks
This commit is contained in:
Michal Meloun 2019-03-19 14:32:54 +00:00
parent 2dd13cf6a4
commit 966e7b050d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=345296
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/arm/include/platformvar.h
View File

@ -90,22 +90,22 @@ typedef struct fdt_platform_class fdt_platform_def_t;
extern platform_method_t fdt_platform_methods[];
#define FDT_PLATFORM_DEF2(NAME, VAR_NAME, NAME_STR, size, compatible, \
delay) \
CTASSERT(delay > 0); \
#define FDT_PLATFORM_DEF2(NAME, VAR_NAME, NAME_STR, _size, _compatible, \
_delay) \
CTASSERT(_delay > 0); \
static fdt_platform_def_t VAR_NAME ## _fdt_platform = { \
.name = NAME_STR, \
.methods = fdt_platform_methods, \
.fdt_compatible = compatible, \
.fdt_compatible = _compatible, \
}; \
static kobj_class_t VAR_NAME ## _baseclasses[] = \
{ (kobj_class_t)&VAR_NAME ## _fdt_platform, NULL }; \
static platform_def_t VAR_NAME ## _platform = { \
NAME_STR, \
NAME ## _methods, \
size, \
VAR_NAME ## _baseclasses, \
delay, \
.name = NAME_STR, \
.methods = NAME ## _methods, \
.size = _size, \
.baseclasses = VAR_NAME ## _baseclasses, \
.delay_count = _delay, \
}; \
DATA_SET(platform_set, VAR_NAME ## _platform)