d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't install h_raw if dealing with clang 3.5.0+ to unbreak the tests2 Jenkins

Browse Source 
job

The h_raw application doesn't do proper bounds checking without the option
being supplied via the build, which means that it doesn't throw signals and
fail as expected

PR: 196430
X-MFC with: r276479
This commit is contained in:
Enji Cooper 2015-01-02 05:40:02 +00:00
parent 2089f5380f
commit 97e4ab0905
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=276527
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh
View File

@ -360,6 +360,9 @@ raw_head()
raw_body()
{
prog="$(atf_get_srcdir)/h_raw"
# Begin FreeBSD
[ -x $prog ] || atf_skip "$prog is missing; skipping testcase"
# End FreeBSD
h_pass "$prog 9"
# Begin FreeBSD

7
lib/libc/tests/ssp/Makefile
View File

@ -9,10 +9,7 @@ WARNS?= 2
CFLAGS.h_raw+= -fstack-protector-all -Wstack-protector
.if ${COMPILER_TYPE} == "clang"
# Disable -fsanitize=bounds until runtime support is done for clang 3.5.0.
.if ${COMPILER_VERSION} < 30500
CFLAGS.h_raw+= -fsanitize=bounds
.endif
.elif ${COMPILER_TYPE} == "gcc"
CFLAGS.h_raw+= --param ssp-buffer-size=1
DPADD+= ${LIBSSP}
@ -29,7 +26,11 @@ PROGS+= h_getcwd
PROGS+= h_memcpy
PROGS+= h_memmove
PROGS+= h_memset
# This testcase doesn't run properly when not compiled with -fsantize=bounds
# with clang, which is currently contingent on a compiler_rt update
.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} < 30500
PROGS+= h_raw
.endif
PROGS+= h_read
PROGS+= h_readlink
PROGS+= h_snprintf