d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove setting BIO_DONE flag for BIOs that have done() method.

Browse Source 
This fixes use-after-free, caused by geom_disk, completing same BIO twice
to save extra allocation, and getting BIO_DONE set after the first.

MFC after:	1 week
This commit is contained in:
Alexander Motin 2014-10-15 18:36:34 +00:00
parent 632d4e706a
commit 99b9076c21
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=273143
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/kern/vfs_bio.c
View File

@ -3618,10 +3618,8 @@ biodone(struct bio *bp)
bp->bio_flags |= BIO_DONE;
wakeup(bp);
mtx_unlock(mtxp);
} else {
bp->bio_flags |= BIO_DONE;
} else
done(bp);
}
}
/*