d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bsdinstall/partedit: Fix UFS auto partitioning

Browse Source 
Fix bsdinstall "Auto (UFS) Guided Disk Setup" and sade(8) "Auto".
The problem is a string comparison failure, it arose during the
dialog(3)/bsddialog(3) form conversion:

 * dialog uses only form.text while bsdialog differentiates between
   form.init and form.value.
 * dialog always allocates memory for form values while bsddialog only
   when a button is pressed.

Reviewed by:		bapt
Differential Revision:	https://reviews.freebsd.org/D35033
This commit is contained in:
Alfonso S. Siciliano 2022-04-30 01:19:30 +02:00
parent 2f6362484c
commit 9b4c606b96
No known key found for this signature in database
GPG Key ID: 3F9EEFACFD371E37
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/bsdinstall/partedit/gpart_ops.c
View File

@ -1154,6 +1154,12 @@ gpart_create(struct gprovider *pp, const char *default_type,
init_allocated = true;
goto addpartform;
}
} else { /* auto partitioning */
items[0].value = strdup(items[0].init);
items[1].value = strdup(items[1].init);
items[2].value = strdup(items[2].init);
if (nitems > 3)
items[3].value = strdup(items[3].init);
}
/*