d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed unused function ll_w_block(). It has always had races due

Browse Source 
to not using splbio(), and has rotted a little.  The races were
probably harmless in practice because this function was only used
for superblock updates, and separate superblock updates are probably
prevented from running into each other by doing part of the update
synchronously.
This commit is contained in:
Bruce Evans 1998-06-21 19:56:31 +00:00
parent be160d60ab
commit 9b7a8fb7d8
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=37102
4 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sys/gnu/ext2fs/ext2_extern.h
View File

@ -80,7 +80,6 @@ struct ext2_group_desc * get_group_desc __P((struct mount * ,
unsigned int , struct buf ** ));
void ext2_discard_prealloc __P((struct inode *));
int ext2_inactive __P((struct vop_inactive_args *));
int ll_w_block __P((struct buf *, int ));
int ext2_new_block __P ((struct mount * mp, unsigned long goal,
int * prealloc_count,
int * prealloc_block));

18
sys/gnu/ext2fs/ext2_linux_ialloc.c
View File

@ -60,24 +60,6 @@ void mark_buffer_dirty(struct buf *bh)
bh->b_flags &= ~(B_READ | B_ERROR);
}
/*
this should write a buffer immediately w/o releasing it
*/
int ll_w_block(struct buf * bp, int waitfor)
{
if (bp->b_flags & B_DELWRI) {
--numdirtybuffers;
if (needsbuffer)
vfs_bio_need_satisfy();
}
bp->b_flags &= ~(B_READ|B_DONE|B_ERROR|B_DELWRI);
bp->b_flags |= B_WRITEINPROG;
bp->b_vp->v_numoutput++;
vfs_busy_pages(bp, 1);
VOP_STRATEGY(bp);
return waitfor ? biowait(bp) : 0;
}
struct ext2_group_desc * get_group_desc (struct mount * mp,
unsigned int block_group,
struct buffer_head ** bh)

1
sys/gnu/fs/ext2fs/ext2_extern.h
View File

@ -80,7 +80,6 @@ struct ext2_group_desc * get_group_desc __P((struct mount * ,
unsigned int , struct buf ** ));
void ext2_discard_prealloc __P((struct inode *));
int ext2_inactive __P((struct vop_inactive_args *));
int ll_w_block __P((struct buf *, int ));
int ext2_new_block __P ((struct mount * mp, unsigned long goal,
int * prealloc_count,
int * prealloc_block));

18
sys/gnu/fs/ext2fs/ext2_linux_ialloc.c
View File

@ -60,24 +60,6 @@ void mark_buffer_dirty(struct buf *bh)
bh->b_flags &= ~(B_READ | B_ERROR);
}
/*
this should write a buffer immediately w/o releasing it
*/
int ll_w_block(struct buf * bp, int waitfor)
{
if (bp->b_flags & B_DELWRI) {
--numdirtybuffers;
if (needsbuffer)
vfs_bio_need_satisfy();
}
bp->b_flags &= ~(B_READ|B_DONE|B_ERROR|B_DELWRI);
bp->b_flags |= B_WRITEINPROG;
bp->b_vp->v_numoutput++;
vfs_busy_pages(bp, 1);
VOP_STRATEGY(bp);
return waitfor ? biowait(bp) : 0;
}
struct ext2_group_desc * get_group_desc (struct mount * mp,
unsigned int block_group,
struct buffer_head ** bh)