fusefs: initialize C++ classes the Coverity way
Coverity complained that I wasn't initializing some class members until the SetUp method. Do it in the constructor instead. Reported by: Coverity Coverity CIDs: 1404352, 1404378 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
This commit is contained in:
parent
4ca1c0b7f7
commit
9c9634d1db
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=352414
@ -108,11 +108,11 @@ int m_backing_fd, m_control_fd, m_test_fd;
|
|||||||
off_t m_filesize;
|
off_t m_filesize;
|
||||||
bool m_direct_io;
|
bool m_direct_io;
|
||||||
|
|
||||||
Io(): m_backing_fd(-1), m_control_fd(-1), m_test_fd(-1), m_direct_io(false) {};
|
Io(): m_backing_fd(-1), m_control_fd(-1), m_test_fd(-1), m_filesize(0),
|
||||||
|
m_direct_io(false) {};
|
||||||
|
|
||||||
void SetUp()
|
void SetUp()
|
||||||
{
|
{
|
||||||
m_filesize = 0;
|
|
||||||
m_backing_fd = open("backing_file", O_RDWR | O_CREAT | O_TRUNC, 0644);
|
m_backing_fd = open("backing_file", O_RDWR | O_CREAT | O_TRUNC, 0644);
|
||||||
if (m_backing_fd < 0)
|
if (m_backing_fd < 0)
|
||||||
FAIL() << strerror(errno);
|
FAIL() << strerror(errno);
|
||||||
|
@ -55,8 +55,11 @@ const static mode_t c_umask = 022;
|
|||||||
|
|
||||||
public:
|
public:
|
||||||
|
|
||||||
virtual void SetUp() {
|
Mknod() {
|
||||||
m_oldmask = umask(c_umask);
|
m_oldmask = umask(c_umask);
|
||||||
|
}
|
||||||
|
|
||||||
|
virtual void SetUp() {
|
||||||
if (geteuid() != 0) {
|
if (geteuid() != 0) {
|
||||||
GTEST_SKIP() << "Only root may use most mknod(2) variations";
|
GTEST_SKIP() << "Only root may use most mknod(2) variations";
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user