d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't do symbol lookups for local symbols. The symbol index in the

Browse Source 
relocation identifies the symbol to which we need to bind. This
solves a problem seen on ia64 where the symbol hash table does not
contain local symbols and thus resulted in unresolved symbols.

Tested on: alpha, i386, ia64
This commit is contained in:
Marcel Moolenaar 2002-04-27 02:48:29 +00:00
parent 624abf8519
commit 9d4f27148f
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=95539
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libexec/rtld-elf/rtld.c
View File

@ -854,20 +854,27 @@ find_symdef(unsigned long symnum, const Obj_Entry *refobj,
ref = refobj->symtab + symnum;
name = refobj->strtab + ref->st_name;
hash = elf_hash(name);
defobj = NULL;
/* Handle STT_SECTION specially. */
if (ELF_ST_TYPE(ref->st_info) == STT_SECTION) {
if (ELF_ST_BIND(ref->st_info) != STB_LOCAL ||
ref->st_shndx != symnum) {
/*
* We don't have to do a full scale lookup if the symbol is local.
* We know it will bind to the instance in this load module; to
* which we already have a pointer (ie ref). By not doing a lookup,
* we not only improve performance, but it also avoids unresolvable
* symbols when local symbols are not in the hash table. This has
* been seen with the ia64 toolchain.
*/
if (ELF_ST_BIND(ref->st_info) != STB_LOCAL) {
if (ELF_ST_TYPE(ref->st_info) == STT_SECTION) {
_rtld_error("%s: Bogus symbol table entry %lu", refobj->path,
symnum);
}
hash = elf_hash(name);
def = symlook_default(name, hash, refobj, &defobj, in_plt);
} else {
def = ref;
defobj = refobj;
} else
def = symlook_default(name, hash, refobj, &defobj, in_plt);
}
/*
* If we found no definition and the reference is weak, treat the