d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Certain vnode buffer list operations were not being spl protected,

Browse Source 
and they needed to be.  Brelse for example can be called at interrupt
level, and the buffer list operations were not being protected from it.
This commit is contained in:
dyson 1996-08-15 06:45:01 +00:00
parent d49604ab58
commit 9e53652005
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/vfs_export.c
View File

@ -36,7 +36,7 @@
* SUCH DAMAGE. * SUCH DAMAGE.
* *
* @(#)vfs_subr.c 8.13 (Berkeley) 4/18/94 * @(#)vfs_subr.c 8.13 (Berkeley) 4/18/94
* $Id: vfs_subr.c,v 1.56 1996/07/24 21:21:43 phk Exp $ * $Id: vfs_subr.c,v 1.57 1996/07/30 18:00:25 bde Exp $
*/ */
/* /*
@ -639,11 +639,14 @@ reassignbuf(bp, newvp)
register struct vnode *newvp; register struct vnode *newvp;
{ {
register struct buflists *listheadp; register struct buflists *listheadp;
int s;
if (newvp == NULL) { if (newvp == NULL) {
printf("reassignbuf: NULL"); printf("reassignbuf: NULL");
return; return;
} }
s = splbio();
/* /*
* Delete from old vnode list, if on one. * Delete from old vnode list, if on one.
*/ */
@ -670,6 +673,7 @@ reassignbuf(bp, newvp)
listheadp = &newvp->v_cleanblkhd; listheadp = &newvp->v_cleanblkhd;
bufinsvn(bp, listheadp); bufinsvn(bp, listheadp);
} }
splx(s);
} }
#ifndef DEVFS_ROOT #ifndef DEVFS_ROOT

6
sys/kern/vfs_subr.c
View File

@ -36,7 +36,7 @@
* SUCH DAMAGE. * SUCH DAMAGE.
* *
* @(#)vfs_subr.c 8.13 (Berkeley) 4/18/94 * @(#)vfs_subr.c 8.13 (Berkeley) 4/18/94
* $Id: vfs_subr.c,v 1.56 1996/07/24 21:21:43 phk Exp $ * $Id: vfs_subr.c,v 1.57 1996/07/30 18:00:25 bde Exp $
*/ */
/* /*
@ -639,11 +639,14 @@ reassignbuf(bp, newvp)
register struct vnode *newvp; register struct vnode *newvp;
{ {
register struct buflists *listheadp; register struct buflists *listheadp;
int s;
if (newvp == NULL) { if (newvp == NULL) {
printf("reassignbuf: NULL"); printf("reassignbuf: NULL");
return; return;
} }
s = splbio();
/* /*
* Delete from old vnode list, if on one. * Delete from old vnode list, if on one.
*/ */
@ -670,6 +673,7 @@ reassignbuf(bp, newvp)
listheadp = &newvp->v_cleanblkhd; listheadp = &newvp->v_cleanblkhd;
bufinsvn(bp, listheadp); bufinsvn(bp, listheadp);
} }
splx(s);
} }
#ifndef DEVFS_ROOT #ifndef DEVFS_ROOT