d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a comment explaining how the PSN works and why there is no need for

Browse Source 
a null terminator. Also mark CID 1394825 as intentional.

Reported by:	Coverity
CID:		1394825
MFC after:	1 week
Sponsored by:	iXsystems Inc.
This commit is contained in:
Marcelo Araujo 2018-08-16 06:31:54 +00:00
parent e30993c2a6
commit 9e59a2e8ce
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=337887
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
usr.sbin/bhyve/pci_nvme.c
View File

@ -1714,6 +1714,11 @@ pci_nvme_parse_opts(struct pci_nvme_softc *sc, char *opts)
} else if (!strcmp("sectsz", xopts)) {
sectsz = atoi(config);
} else if (!strcmp("ser", xopts)) {
/*
* This field indicates the Product Serial Number in
* 8-bit ASCII, unused bytes should be NULL characters.
* Ref: NVM Express Management Interface 1.0a.
*/
memset(sc->ctrldata.sn, 0, sizeof(sc->ctrldata.sn));
strncpy(sc->ctrldata.sn, config,
sizeof(sc->ctrldata.sn));