d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

uefisign: fix handling of errors from child proc

Browse Source 
Close the unused pipe file descriptors so the parent will notice if
the child exits prematurely.  Previously, the parent would block
forever on a read from the pipe.

    $ uefisign -c foo.cert -k foo.key -o loader.efi loader.efi.unsigned
    uefisign: section points inside the headers
    load: 0.06  cmd: uefisign 4502 [piperd] 7.25r 0.00u 0.00s 0% 5968k
    ... _sleep+0x1be pipe_read+0x3d6 kern_readv+0x8c sys_read+0x83 ...

Reviewed by:	trasz
MFC after:	1 week
Sponsored by:	Dell EMC Isilon
Differential Revision:	https://reviews.freebsd.org/D29605
This commit is contained in:
Eric van Gyzen 2021-04-06 09:36:52 -05:00
parent 9857e00a52
commit 9e6158d274
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/uefisign/uefisign.c
View File

@ -410,8 +410,12 @@ main(int argc, char **argv)
if (pid < 0)
err(1, "fork");
if (pid == 0)
if (pid == 0) {
close(pipefds[0]);
exit(child(inpath, outpath, pipefds[1], Vflag, vflag));
}
close(pipefds[1]);
if (!Vflag) {
certfp = checked_fopen(certpath, "r");