d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove comments and assertions that are no longer valid after r330809.

Browse Source 
r330809 replaced duplication of devdesc struct fields with an embedded copy
of the devdesc struct, to avoid fragility.  That means all the scattered
comments indicating that structs must match are no longer valid.  Likewise
asserts that attempted to mitigate some of the old fragility.

Reviewed by:	imp@
This commit is contained in:
Ian Lepore 2018-06-05 22:13:45 +00:00
parent b941bc1d6e
commit 9f6fd8397c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=334695
6 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
stand/common/disk.h
View File

@ -81,9 +81,8 @@
#ifndef _DISK_H
#define _DISK_H
/* Note: Must match the 'struct devdesc' in stand.h */
struct disk_devdesc {
struct devdesc dd;
struct devdesc dd; /* Must be first. */
int d_slice;
int d_partition;
uint64_t d_offset;

2
stand/i386/libi386/biosdisk.c
View File

@ -78,8 +78,6 @@ struct ptable {
#include "geliboot.c"
#endif /* LOADER_GELI_SUPPORT */
CTASSERT(sizeof(struct i386_devdesc) >= sizeof(struct disk_devdesc));
#define BIOS_NUMDRIVES 0x475
#define BIOSDISK_SECSIZE 512
#define BUFSIZE (1 * BIOSDISK_SECSIZE)

4
stand/i386/libi386/libi386.h
View File

@ -29,11 +29,9 @@
/*
* i386 fully-qualified device descriptor.
* Note, this must match struct zfs_devdesc for zfs support.
*/
/* Note: Must match the 'struct devdesc' in stand.h */
struct i386_devdesc {
struct devdesc dd;
struct devdesc dd; /* Must be first. */
union
{
struct

3
stand/uboot/lib/libuboot.h
View File

@ -27,9 +27,8 @@
* $FreeBSD$
*/
/* Note: Must match the 'struct devdesc' in stand.h */
struct uboot_devdesc {
struct devdesc dd;
struct devdesc dd; /* Must be first. */
union {
struct {
int slice;

1
stand/userboot/userboot/main.c
View File

@ -159,7 +159,6 @@ extract_currdev(void)
#if defined(USERBOOT_ZFS_SUPPORT)
struct zfs_devdesc zdev;
CTASSERT(sizeof(struct disk_devdesc) >= sizeof(struct zfs_devdesc));
if (userboot_zfs_found) {
/* Leave the pool/root guid's unassigned */

5
stand/zfs/libzfs.h
View File

@ -33,12 +33,9 @@
/*
* ZFS fully-qualified device descriptor.
* Arch-specific device descriptors should be binary compatible with this
* structure if they are to support ZFS.
*/
/* Note: Must match the 'struct devdesc' in stand.h */
struct zfs_devdesc {
struct devdesc dd;
struct devdesc dd; /* Must be first. */
uint64_t pool_guid;
uint64_t root_guid;
};