From 9fc2bcf662f5477c92669d634f59d849d18a27db Mon Sep 17 00:00:00 2001 From: Jonathan Lemon Date: Tue, 31 Aug 1999 16:34:20 +0000 Subject: [PATCH] Simplify, and return an error if the user attempts to set a TCP time value which results in < 1 tick. Suggested by: bde --- sys/netinet/tcp_timer.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sys/netinet/tcp_timer.c b/sys/netinet/tcp_timer.c index 74752b83d3ab..591fb18177a1 100644 --- a/sys/netinet/tcp_timer.c +++ b/sys/netinet/tcp_timer.c @@ -71,17 +71,13 @@ sysctl_msec_to_ticks SYSCTL_HANDLER_ARGS tt = *(int *)oidp->oid_arg1; s = tt * 1000 / hz; - error = SYSCTL_OUT(req, &s, sizeof(int)); + error = sysctl_handle_int(oidp, &s, 0, req); if (error || !req->newptr) return (error); - error = SYSCTL_IN(req, &s, sizeof(int)); - if (error) - return (error); - tt = s * hz / 1000; - if (tt == 0 && s > 0) - tt++; + if (tt < 1) + return (EINVAL); *(int *)oidp->oid_arg1 = tt; return (0);