d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cache: tidy up handling of foo/bar lookups where foo is not a directory

Browse Source 
The code was performing an avoidable check for doomed state to account
for foo being a VDIR but turning VBAD. Now that dooming puts a vnode
in a permanent "modify" state this is no longer necessary as the final
status check will catch it.
This commit is contained in:
Mateusz Guzik 2021-01-26 17:19:12 +01:00
parent a51eca7936
commit a098a831a1
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/kern/vfs_cache.c
View File

@ -5328,20 +5328,11 @@ cache_fplookup_failed_vexec(struct cache_fpl *fpl, int error)
}
/*
* Hack: they may be looking up foo/bar, where foo is a
* regular file. In such a case we need to turn ENOTDIR,
* but we may happen to get here with a different error.
* Hack: they may be looking up foo/bar, where foo is not a directory.
* In such a case we need to return ENOTDIR, but we may happen to get
* here with a different error.
*/
if (dvp->v_type != VDIR) {
/*
* The check here is predominantly to catch
* EOPNOTSUPP from dead_vnodeops. If the vnode
* gets doomed past this point it is going to
* fail seqc verification.
*/
if (VN_IS_DOOMED(dvp)) {
return (cache_fpl_aborted(fpl));
}
error = ENOTDIR;
}