Use strlcpy instead of strcpy when copying the bridge name to ifr.ifr_name
to avoid buffer overflows MFC after: 1 week Reported by: Coverity CID: 1006735, 1006737, 1006738
This commit is contained in:
parent
f9fe16497a
commit
a0cc1855e3
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=311290
@ -485,7 +485,7 @@ bridge_set_if_up(const char* b_name, int8_t up)
|
|||||||
struct ifreq ifr;
|
struct ifreq ifr;
|
||||||
|
|
||||||
bzero(&ifr, sizeof(ifr));
|
bzero(&ifr, sizeof(ifr));
|
||||||
strcpy(ifr.ifr_name, b_name);
|
strlcpy(ifr.ifr_name, b_name, sizeof(ifr.ifr_name));
|
||||||
if (ioctl(sock, SIOCGIFFLAGS, (caddr_t) &ifr) < 0) {
|
if (ioctl(sock, SIOCGIFFLAGS, (caddr_t) &ifr) < 0) {
|
||||||
syslog(LOG_ERR, "set bridge up: ioctl(SIOCGIFFLAGS) "
|
syslog(LOG_ERR, "set bridge up: ioctl(SIOCGIFFLAGS) "
|
||||||
"failed: %s", strerror(errno));
|
"failed: %s", strerror(errno));
|
||||||
@ -516,7 +516,7 @@ bridge_create(const char *b_name)
|
|||||||
struct ifreq ifr;
|
struct ifreq ifr;
|
||||||
|
|
||||||
bzero(&ifr, sizeof(ifr));
|
bzero(&ifr, sizeof(ifr));
|
||||||
strcpy(ifr.ifr_name, b_name);
|
strlcpy(ifr.ifr_name, b_name, sizeof(ifr.ifr_name));
|
||||||
|
|
||||||
if (ioctl(sock, SIOCIFCREATE, &ifr) < 0) {
|
if (ioctl(sock, SIOCIFCREATE, &ifr) < 0) {
|
||||||
syslog(LOG_ERR, "create bridge: ioctl(SIOCIFCREATE) "
|
syslog(LOG_ERR, "create bridge: ioctl(SIOCIFCREATE) "
|
||||||
@ -549,7 +549,7 @@ bridge_destroy(const char *b_name)
|
|||||||
struct ifreq ifr;
|
struct ifreq ifr;
|
||||||
|
|
||||||
bzero(&ifr, sizeof(ifr));
|
bzero(&ifr, sizeof(ifr));
|
||||||
strcpy(ifr.ifr_name, b_name);
|
strlcpy(ifr.ifr_name, b_name, sizeof(ifr.ifr_name));
|
||||||
|
|
||||||
if (ioctl(sock, SIOCIFDESTROY, &ifr) < 0) {
|
if (ioctl(sock, SIOCIFDESTROY, &ifr) < 0) {
|
||||||
syslog(LOG_ERR, "destroy bridge: ioctl(SIOCIFDESTROY) "
|
syslog(LOG_ERR, "destroy bridge: ioctl(SIOCIFDESTROY) "
|
||||||
|
Loading…
Reference in New Issue
Block a user