d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor the code a little bit to avoid NULL deference when

Browse Source 
allocation was failed.

Reported by:	Coverity
CID:		1238915
MFC after:	1 week
This commit is contained in:
Xin LI 2014-09-25 22:22:51 +00:00
parent 0a8534f083
commit a2cf0c3c61
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=272141
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
contrib/hyperv/tools/hv_kvp_daemon.c
View File

@ -612,18 +612,17 @@ kvp_mac_to_if_name(char *mac)
sdl = (struct sockaddr_dl *)(uintptr_t)ifaddrs_ptr->ifa_addr;
if (sdl->sdl_type == IFT_ETHER) {
buf_ptr = strdup(ether_ntoa((struct ether_addr *)(LLADDR(sdl))));
for (i = 0; i < strlen(buf_ptr); i++)
{
buf_ptr[i] = toupper(buf_ptr[i]);
}
if (buf_ptr != NULL) {
for (i = 0; i < strlen(buf_ptr); i++)
buf_ptr[i] = toupper(buf_ptr[i]);
if (strncmp(buf_ptr, mac, strlen(mac)) == 0) {
/* Caller will free the memory */
if_name = strdup(ifaddrs_ptr->ifa_name);
free(buf_ptr);
break;
}else if (buf_ptr != NULL) {
free(buf_ptr);
if (strncmp(buf_ptr, mac, strlen(mac)) == 0) {
/* Caller will free the memory */
if_name = strdup(ifaddrs_ptr->ifa_name);
free(buf_ptr);
break;
} else
free(buf_ptr);
}
}
} while ((ifaddrs_ptr = ifaddrs_ptr->ifa_next) != NULL);