- Correct logic in if statement - we want to allocate temporary buffer
when someone is passing new rules, not when he only want to read them. Because of this bug, even if the given rules were incorrect, they ended up in rule_string. - Add missing protection for rule_string when coping it. Reviewed by: rwatson MFC after: 1 week
This commit is contained in:
parent
b3c11b5b91
commit
a3ce3b6d35
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=189830
@ -341,10 +341,12 @@ sysctl_rules(SYSCTL_HANDLER_ARGS)
|
||||
int error;
|
||||
|
||||
new_string = NULL;
|
||||
if (req->newptr == NULL) {
|
||||
if (req->newptr != NULL) {
|
||||
new_string = malloc(MAC_RULE_STRING_LEN, M_PORTACL,
|
||||
M_WAITOK | M_ZERO);
|
||||
mtx_lock(&rule_mtx);
|
||||
strcpy(new_string, rule_string);
|
||||
mtx_unlock(&rule_mtx);
|
||||
string = new_string;
|
||||
} else
|
||||
string = rule_string;
|
||||
|
Loading…
Reference in New Issue
Block a user