d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove an impossible condition from unionfs_lock()

Browse Source 
We hold the vnode interlock, so vnode private data cannot suddenly
become NULL.

Tested by:	pho
Reviewed by:	kib, markj
Differential Revision:	https://reviews.freebsd.org/D39272
This commit is contained in:
Jason A. Harmening 2023-01-16 15:48:11 -06:00
parent a18c403fbd
commit a5d82b55fe
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/fs/unionfs/union_vnops.c
View File

@ -1982,14 +1982,6 @@ unionfs_lock(struct vop_lock1_args *ap)
vholdnz(uvp);
uhold = 1;
VOP_UNLOCK(uvp);
unp = VTOUNIONFS(vp);
if (unp == NULL) {
/* vnode is released. */
VI_UNLOCK(vp);
VOP_UNLOCK(lvp);
vdrop(uvp);
return (EBUSY);
}
}
VI_LOCK_FLAGS(lvp, MTX_DUPOK);
flags |= LK_INTERLOCK;