d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb(4): Ignore port resume failures.

Browse Source 
If port resume fails, likely the USB device is detached. Ignore such errors,
because else the USB stack might try forever trying to resume the device,
before it will proceed detaching it.

MFC after:	1 week
Sponsored by:	NVIDIA Networking
This commit is contained in:
Hans Petter Selasky 2022-02-02 12:59:00 +01:00
parent e7c5442162
commit a88e1a04df
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/dev/usb/usb_hub.c
View File

@ -4,7 +4,7 @@
*
* Copyright (c) 1998 The NetBSD Foundation, Inc. All rights reserved.
* Copyright (c) 1998 Lennart Augustsson. All rights reserved.
* Copyright (c) 2008-2010 Hans Petter Selasky. All rights reserved.
* Copyright (c) 2008-2022 Hans Petter Selasky. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@ -2651,18 +2651,15 @@ usb_dev_resume_peer(struct usb_device *udev)
/* resume current port (Valid in Host and Device Mode) */
err = usbd_req_clear_port_feature(udev->parent_hub,
NULL, udev->port_no, UHF_PORT_SUSPEND);
if (err) {
DPRINTFN(0, "Resuming port failed\n");
return;
}
} else {
/* resume current port (Valid in Host and Device Mode) */
err = usbd_req_set_port_link_state(udev->parent_hub,
NULL, udev->port_no, UPS_PORT_LS_U0);
if (err) {
DPRINTFN(0, "Resuming port failed\n");
return;
}
}
if (err != 0) {
DPRINTFN(0, "Resuming port failed: %s (ignored)\n",
usbd_errstr(err));
}
/* resume settle time */