d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vfs: handle doomed vnodes in vdefer_inactive

Browse Source 
vgone dooms the vnode while keeping VI_OWEINACT set and then drops the
interlock.

vputx can pick up the interlock and pass it to vdefer_inactive since the
flag is set.

The race is harmless, just don't defer anything as vgone will take care of it.

Reported by:	pho
This commit is contained in:
Mateusz Guzik 2020-01-07 20:24:21 +00:00
parent 241972461f
commit a9a047bc87
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=356470
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/kern/vfs_subr.c
View File

@ -3018,8 +3018,10 @@ vdefer_inactive(struct vnode *vp)
ASSERT_VI_LOCKED(vp, __func__);
VNASSERT(vp->v_iflag & VI_OWEINACT, vp,
("%s: vnode without VI_OWEINACT", __func__));
VNASSERT(!VN_IS_DOOMED(vp), vp,
("%s: doomed vnode", __func__));
if (VN_IS_DOOMED(vp)) {
vdropl(vp);
return;
}
if (vp->v_iflag & VI_DEFINACT) {
VNASSERT(vp->v_holdcnt > 1, vp, ("lost hold count"));
vdropl(vp);
@ -3036,8 +3038,7 @@ vdefer_inactive_cond(struct vnode *vp)
VI_LOCK(vp);
VNASSERT(vp->v_holdcnt > 0, vp, ("vnode without hold count"));
if (VN_IS_DOOMED(vp) ||
(vp->v_iflag & VI_OWEINACT) == 0) {
if ((vp->v_iflag & VI_OWEINACT) == 0) {
vdropl(vp);
return;
}