d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove 'periph == NULL' check from bunch of periph drivers.

Browse Source 
This condition can never be true as functions are called from single place
and the checks just pollute the code and confuse Clang Static Analyzer.
This commit is contained in:
Alexander Motin 2012-10-10 18:10:11 +00:00
parent 500cbe13db
commit aa2a1aaf90
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=241404
10 changed files with 0 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/cam/ata/ata_da.c
View File

@ -943,11 +943,6 @@ adaregister(struct cam_periph *periph, void *arg)
int legacy_id, quirks;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("adaregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("adaregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);

5
sys/cam/ata/ata_pmp.c
View File

@ -367,11 +367,6 @@ pmpregister(struct cam_periph *periph, void *arg)
struct ccb_getdev *cgd;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("pmpregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("pmpregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);

5
sys/cam/ata/ata_xpt.c
View File

@ -224,11 +224,6 @@ proberegister(struct cam_periph *periph, void *arg)
probe_softc *softc;
request_ccb = (union ccb *)arg;
if (periph == NULL) {
printf("proberegister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (request_ccb == NULL) {
printf("proberegister: no probe CCB, "
"can't register device\n");

4
sys/cam/scsi/scsi_cd.c
View File

@ -692,10 +692,6 @@ cdregister(struct cam_periph *periph, void *arg)
caddr_t match;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("cdregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("cdregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_ch.c
View File

@ -324,11 +324,6 @@ chregister(struct cam_periph *periph, void *arg)
struct ccb_pathinq cpi;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("chregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("chregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_da.c
View File

@ -1583,11 +1583,6 @@ daregister(struct cam_periph *periph, void *arg)
caddr_t match;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("daregister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("daregister: no getdev CCB, can't register device\n");
return(CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_pass.c
View File

@ -312,11 +312,6 @@ passregister(struct cam_periph *periph, void *arg)
int no_tags;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("%s: periph was NULL!!\n", __func__);
return(CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("%s: no getdev CCB, can't register device\n", __func__);
return(CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_sa.c
View File

@ -1445,11 +1445,6 @@ saregister(struct cam_periph *periph, void *arg)
int i;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("saregister: periph was NULL!!\n");
return (CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("saregister: no getdev CCB, can't register device\n");
return (CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_sg.c
View File

@ -261,11 +261,6 @@ sgregister(struct cam_periph *periph, void *arg)
int no_tags;
cgd = (struct ccb_getdev *)arg;
if (periph == NULL) {
printf("sgregister: periph was NULL!!\n");
return (CAM_REQ_CMP_ERR);
}
if (cgd == NULL) {
printf("sgregister: no getdev CCB, can't register device\n");
return (CAM_REQ_CMP_ERR);

5
sys/cam/scsi/scsi_xpt.c
View File

@ -615,11 +615,6 @@ proberegister(struct cam_periph *periph, void *arg)
probe_softc *softc;
request_ccb = (union ccb *)arg;
if (periph == NULL) {
printf("proberegister: periph was NULL!!\n");
return(CAM_REQ_CMP_ERR);
}
if (request_ccb == NULL) {
printf("proberegister: no probe CCB, "
"can't register device\n");