d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix security hole in YP password support, which wouldmake +user entries

Browse Source 
act like + entries in some cases.  Requires support in libc from next
commit.
This commit is contained in:
Garrett Wollman 1994-09-20 21:40:12 +00:00
parent 38a03467df
commit ab5f8d28a4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=2934
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
usr.sbin/pwd_mkdb/pwd_mkdb.c
View File

@ -178,7 +178,13 @@ main(argc, argv)
data.data = (u_char *)buf;
key.data = (u_char *)tbuf;
for (cnt = 1; scan(fp, &pwd); ++cnt) {
if(pwd.pw_name[0] == '+') yp_enabled = 1;
if(pwd.pw_name[0] == '+') {
if(pwd.pw_name[1] && !yp_enabled) {
yp_enabled = 1;
} else if(!pwd.pw_name[1]) {
yp_enabled = -1;
}
}
#define COMPACT(e) t = e; while (*p++ = *t++);
/* Create insecure data. */
p = buf;
@ -230,6 +236,8 @@ main(argc, argv)
}
/* If YP enabled, set flag. */
if(yp_enabled) {
buf[0] = yp_enabled + 2;
data.size = 1;
tbuf[0] = _PW_KEYYPENABLED;
key.size = 1;
if ((dp->put)(dp, &key, &data, R_NOOVERWRITE) == -1)
@ -295,12 +303,13 @@ main(argc, argv)
if ((dp->put)(edp, &key, &data, R_NOOVERWRITE) == -1)
error("put");
}
/* If YP enabled, set flag. */
if(yp_enabled) {
buf[0] = yp_enabled + 2;
data.size = 1;
tbuf[0] = _PW_KEYYPENABLED;
key.size = 1;
if ((dp->put)(edp, &key, &data, R_NOOVERWRITE) == -1)
if ((dp->put)(dp, &key, &data, R_NOOVERWRITE) == -1)
error("put");
}