d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tcp: remove INP_DROPPED check from notify functions

Browse Source 
These functions tcp_notify(), tcp_drop_syn_sent() and tcp_mtudisc()
are called from tcp*_ctlinput*() right after successfull
in_pcblookup*().  They shall never get a pcb that is dropped.
This commit is contained in:
Gleb Smirnoff 2022-11-08 10:24:39 -08:00
parent f567d55f51
commit ada90cb978
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netinet/tcp_subr.c
View File

@ -2596,9 +2596,6 @@ tcp_notify(struct inpcb *inp, int error)
INP_WLOCK_ASSERT(inp);
if (inp->inp_flags & INP_DROPPED)
return (inp);
tp = intotcpcb(inp);
KASSERT(tp != NULL, ("tcp_notify: tp == NULL"));
@ -3319,9 +3316,6 @@ tcp_drop_syn_sent(struct inpcb *inp, int errno)
NET_EPOCH_ASSERT();
INP_WLOCK_ASSERT(inp);
if (inp->inp_flags & INP_DROPPED)
return (inp);
tp = intotcpcb(inp);
if (tp->t_state != TCPS_SYN_SENT)
return (inp);
@ -3356,8 +3350,6 @@ tcp_mtudisc(struct inpcb *inp, int mtuoffer)
struct socket *so;
INP_WLOCK_ASSERT(inp);
if (inp->inp_flags & INP_DROPPED)
return (inp);
tp = intotcpcb(inp);
KASSERT(tp != NULL, ("tcp_mtudisc: tp == NULL"));