d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid a buffer overwrite in rip6_output() when computing the checksum

Browse Source 
as requested by the user via the IPPROTO_IPV6 level socket option
IPV6_CHECKSUM. The check if there are enough bytes in the packet to
store the checksum at the requested offset was wrong by 1.

Reviewed by:		bz@
MFC after:		1 week
Sponsored by:		Netflix, Inc.
Differential Revision:	https://reviews.freebsd.org/D19967
This commit is contained in:
Michael Tuexen 2019-04-19 17:21:35 +00:00
parent 2f041b74b9
commit ae7c65b171
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=346401
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/netinet6/raw_ip6.c
View File

@ -495,7 +495,7 @@ rip6_output(struct mbuf *m, struct socket *so, ...)
off = offsetof(struct icmp6_hdr, icmp6_cksum);
else
off = in6p->in6p_cksum;
if (plen < off + 1) {
if (plen < off + 2) {
error = EINVAL;
goto bad;
}