d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move the setlogin() call a little earlier.. It was being done in the child

Browse Source 
process - which would be no longer allowed if the setlogin() changes go
through.  Now the parent (the session leader, when started by inetd) does it.
This commit is contained in:
Peter Wemm 1995-11-12 18:31:23 +00:00
parent a07ffb0cda
commit b048c73588
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=12240
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libexec/rshd/rshd.c
View File

@ -469,6 +469,11 @@ doit(fromp)
error("Logins currently disabled.\n");
exit(1);
}
#if BSD > 43
/* before fork, while we're session leader */
if (setlogin(pwd->pw_name) < 0)
syslog(LOG_ERR, "setlogin() failed: %m");
#endif
(void) write(STDERR_FILENO, "\0", 1);
sent_null = 1;
@ -643,10 +648,6 @@ doit(fromp)
}
if (*pwd->pw_shell == '\0')
pwd->pw_shell = _PATH_BSHELL;
#if BSD > 43
if (setlogin(pwd->pw_name) < 0)
syslog(LOG_ERR, "setlogin() failed: %m");
#endif
(void) setgid((gid_t)pwd->pw_gid);
initgroups(pwd->pw_name, pwd->pw_gid);
(void) setuid((uid_t)pwd->pw_uid);