d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Quiet compiler warnings for fget_noref and fdget_noref

Browse Source 
Summary:
Typecasting both parts of the comparison to u_int quiets compiler
warnings about signed/unsigned comparison and takes care of positive
and negative numbers for the file descriptor in a single comparison.

Obtained from:	Juniper Netwowrks, Inc.

Reviewers: mjg

Subscribers: imp

Differential Revision: https://reviews.freebsd.org/D39593
This commit is contained in:
Stephen J. Kiernan 2023-04-15 23:50:54 -04:00
parent 0ab68e9272
commit b1a00c2b13
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/sys/filedesc.h
View File

@ -303,7 +303,7 @@ fget_noref(struct filedesc *fdp, int fd)
FILEDESC_LOCK_ASSERT(fdp);
if (__predict_false((u_int)fd >= fdp->fd_nfiles))
if (__predict_false((u_int)fd >= (u_int)fdp->fd_nfiles))
return (NULL);
return (fdp->fd_ofiles[fd].fde_file);
@ -316,7 +316,7 @@ fdeget_noref(struct filedesc *fdp, int fd)
FILEDESC_LOCK_ASSERT(fdp);
if (__predict_false((u_int)fd >= fdp->fd_nfiles))
if (__predict_false((u_int)fd >= (u_int)fdp->fd_nfiles))
return (NULL);
fde = &fdp->fd_ofiles[fd];