d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't adjust the program counter to an invalid address after reaching a

Browse Source 
breakpoint. The value doesn't need to be adjusted as it is already
correctly returned from the kernel.

This allows lldb to set breakpoints, and stop on them, however more work
is needed, for example single stepping fails to stop.

Discussed with:	emaste
This commit is contained in:
Andrew Turner 2015-12-22 17:18:40 +00:00
parent b7200a19e6
commit b1eb23b26b
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=292611
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/llvm/tools/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp
View File

@ -260,13 +260,9 @@ RegisterContextPOSIXProcessMonitor_arm64::HardwareSingleStep(bool enable)
bool
RegisterContextPOSIXProcessMonitor_arm64::UpdateAfterBreakpoint()
{
// PC points one byte past the int3 responsible for the breakpoint.
lldb::addr_t pc;
if ((pc = GetPC()) == LLDB_INVALID_ADDRESS)
if (GetPC() == LLDB_INVALID_ADDRESS)
return false;
SetPC(pc - 1);
return true;
}