d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make cron login class savvy.

Browse Source 
Use setusercontext() rather than setuid()/setgid()/setlogin()/initgroups()
which is all handled. Login environment is NOT set by this call as crontab
provides its own means of doing so.
This commit is contained in:
David Nugent 1997-01-20 15:31:33 +00:00
parent 7aa571fe7e
commit b25b7bc1be
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=21895
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.sbin/cron/cron/Makefile
View File

@ -4,6 +4,8 @@ PROG= cron
SRCS= cron.c database.c do_command.c job.c user.c popen.c
MAN8= cron.8
CFLAGS+=-DLOGIN_CAP
.if exists(${.OBJDIR}/../lib)
LDDESTDIR+= -L${.OBJDIR}/../lib
DPADD+= ${.OBJDIR}/../lib/libcron.a

15
usr.sbin/cron/cron/do_command.c
View File

@ -28,6 +28,9 @@ static char rcsid[] = "$FreeBSD$";
#if defined(SYSLOG)
# include <syslog.h>
#endif
#if defined(LOGIN_CAP)
# include <login_cap.h>
#endif
static void child_process __P((entry *, user *)),
@ -77,6 +80,10 @@ child_process(e, u)
register char *input_data;
char *usernm, *mailto;
int children = 0;
# if defined(LOGIN_CAP)
struct passwd *pwd = getpwuid(e->uid);
login_cap_t *lc = login_getclass(pwd);
# endif
Debug(DPROC, ("[%d] child_process('%s')\n", getpid(), e->cmd))
@ -212,6 +219,13 @@ child_process(e, u)
*/
do_univ(u);
# if defined(LOGIN_CAP)
/* Set user's entire context, but skip the environment
* as cron provides a separate interface for this
*/
setusercontext(lc, pwd, e->uid, LOGIN_SETALL & ~(LOGIN_SETPATH|LOGIN_SETENV));
login_close(lc);
# else
/* set our directory, uid and gid. Set gid first, since once
* we set uid, we've lost root privledges.
*/
@ -221,6 +235,7 @@ child_process(e, u)
# endif
setlogin(usernm);
setuid(e->uid); /* we aren't root after this... */
#endif
chdir(env_get("HOME", e->envp));
/* exec the command.