d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unused variable warnings in tcp_hpts.c

Browse Source 
With clang 15, the following -Werror warning is produced:

    sys/netinet/tcp_hpts.c:1114:10: error: variable 'paced_cnt' set but not used [-Werror,-Wunused-but-set-variable]
            int32_t paced_cnt = 0;
                    ^
    sys/netinet/tcp_hpts.c:1112:11: error: variable 'total_slots_processed' set but not used [-Werror,-Wunused-but-set-variable]
            uint64_t total_slots_processed = 0;
                     ^

The 'paced_cnt' variable was in tcp_hpts.c when it was first added, and
the 'total_slots_processed' variable was added in d7955cc0ff, but
both appear to have been debugging aids that have never been used, so
remove them.

MFC after:	3 days
This commit is contained in:
Dimitry Andric 2022-08-15 20:14:39 +02:00
parent db6b32867d
commit b33bfe6e15
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netinet/tcp_hpts.c
View File

@ -1109,9 +1109,7 @@ tcp_hptsi(struct tcp_hpts_entry *hpts, int from_callout)
struct tcpcb *tp;
struct inpcb *inp;
struct timeval tv;
uint64_t total_slots_processed = 0;
int32_t slots_to_run, i, error;
int32_t paced_cnt = 0;
int32_t loop_cnt = 0;
int32_t did_prefetch = 0;
int32_t prefetch_ninp = 0;
@ -1258,8 +1256,6 @@ tcp_hptsi(struct tcp_hpts_entry *hpts, int from_callout)
/* Record the new position */
orig_exit_slot = runningslot;
}
total_slots_processed++;
paced_cnt++;
INP_WLOCK(inp);
if (inp->inp_hpts_cpu_set == 0) {